974
Review Please (programming.dev)
you are viewing a single comment's thread
view the rest of the comments
[-] BrianTheeBiscuiteer@lemmy.world 1 points 7 months ago

That wasn't me, but that also used to be me. I learned to pick my battles, especially with complex code bases, and tried to keep scope creep in the name of improvement to like a dozen lines (provided it was fully tested).

[-] jjjalljs@ttrpg.network 2 points 7 months ago

I think it's definitely a thing most people grow out of when they gain experience.

My boss told me about how when he was new he rewrote a whole chunk of the front end. His boss gave him a talking to about how you can't just go and do that when you're working with a team.

At an old job I just opened a PR to apply a code formatter to an internal project I wasn't even a routine contributor to. PR was rejected and I learned a valuable lesson about talking and getting buy-in before making sweeping changes.

this post was submitted on 29 Mar 2024
974 points (98.3% liked)

Programmer Humor

19588 readers
490 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS