813
submitted 23 hours ago* (last edited 23 hours ago) by Maven@lemmy.zip to c/programmer_humor@programming.dev
you are viewing a single comment's thread
view the rest of the comments
[-] Hawke@lemmy.world 69 points 22 hours ago

“Changes” are not the same thing as “files”.

I’d expect that files that are not in version control would not be touched.

[-] MajorHavoc@programming.dev 13 points 16 hours ago* (last edited 15 hours ago)

Yeah. That's discussed in more detail in the code change that resulted from the issue report.

It's a ballsy move by the VSCode team to not only include git clean but to keep it after numerous issue reports.

As others discussed in that thread, git clean has no business being offered in a graphical menu where a git novice may find it.

That said, I do think the expanded warning mesage they added addresses the issue by calling out that whatever git may think, the user is about to lose some files.

[-] EleventhHour@lemmy.world 11 points 21 hours ago* (last edited 21 hours ago)

Apparently, it means changes to the directory structure and what files are in them, not changes within the files themselves. It really ought to be more clear about this.

[-] MajorHavoc@programming.dev 4 points 16 hours ago* (last edited 16 hours ago)

Yeah. They did substantially modify the message to make it much clearer, thankfully.

[-] BatmanAoD@programming.dev 3 points 19 hours ago

It means both.

[-] Pyro@programming.dev 3 points 21 hours ago* (last edited 21 hours ago)

"Changes" encompass more than you think. Creating / Deleting files are also changes, not just edits to a file.

  • If the change is an edit to a tracked file, "Discard Changes" will reverse the edit.
  • If the change is deleting a tracked file, "Discard Changes" will restore it back.
  • If the change is a new untracked file, "Discard Changes" will remove it as intended.

It can also be all of them at the same time, which is why VSCode uses "Changes" instead of "Files".

[-] Hawke@lemmy.world 25 points 21 hours ago

And the terminology is misleading, resulting in problems. shrug.

[-] Eranziel@lemmy.world -1 points 19 hours ago

I find it difficult to lay the blame with VSCode when the terminology belongs to git, which (even 7 years ago) was an industry standard technology.

People using tools they don't understand and plowing ahead through scary warnings will always encounter problems.

[-] candybrie@lemmy.world 8 points 17 hours ago

If the change is a new untracked file

Wasn't the issue that it deleted a bunch of preexisting untracked files? So old untracked files.

this post was submitted on 20 Nov 2024
813 points (97.4% liked)

Programmer Humor

19622 readers
2575 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS