5
submitted 11 months ago* (last edited 11 months ago) by tengkuizdihar@discuss.online to c/code_review@programming.dev

I'm making an offline first, note taking application made with rust+tauri. I've reviewed this before with one of my friend and he checks everything from the way I use the library, how I uses my nonces, salt, and the like. But It's never a bad thing to ask you guys for some thought, if any.

Please take it slow, assume the best, and be gentle with me.

top 3 comments
sorted by: hot top controversial new old
[-] tengkuizdihar@discuss.online 1 points 11 months ago

Also about the rule

To ensure that people actually get their code reviewed we have a rule in place where you need to review at least two other people’s code before you can request your own review

I guess this post is an exception huh? I'll try to review other codes if there's a new post.

[-] Ategon@programming.dev 2 points 11 months ago* (last edited 11 months ago)

yeah that was updated a bit ago to let first requests be free. Looks like for some reason this post didnt federate to p.d until recently though

~~Ill check out the code later in the week~~ Edit: exams are taking too much of my time, maybe after exams

[-] tengkuizdihar@discuss.online 1 points 11 months ago

I'm just going to move on from discuss.social.. somehow programming.dev is a lot faster when federating these days. Can be logged into too from jerboa!

this post was submitted on 24 Nov 2023
5 points (100.0% liked)

Code Review

155 readers
1 users here now

Welcome to the programming.dev code review community! This is a place where you can review other people's code or request reviews on your own

Before posting please read the sections below (click on one to expand it)

What is a code review?

What is a code review?

A code review is a process where people who did not write a piece of code look over it to find errors, suggest improvements, and make sure it follows coding standards

When doing a code review look for these aspects:

  1. Correctness: Does the code behave as expected and meet the requirements?
  2. Readability: Is the code easy to understand and maintain?
  3. Efficiency: Are there more efficient ways to accomplish the same task?
  4. Best Practices: Does the code follow established coding standards and best practices?
  5. Security: Are there potential security vulnerabilities?
  6. Scalability: Will the code perform well as the application scales?

Post Guidelines

Guidelines

  • Put the programming language you used for your code in square brackets ahead of your post title. e.g. [Python], [React], [C#], etc.
  • Provide a link to a spot where people can view your code (e.g. github, etc.) in your post body
  • In your post title put a small description of what the thing is that you want reviewed and then you can expand on that in more details if you want in your post body

Rules

Rules

Any code review requests you post after your first must be done after you have reviewed two other people's code (and then you need another two for each request after that as well).

Youre free to post your first code review request in this community though without needing to follow this


Credits

Credits

Icon base by Lorc under CC BY 3.0 with modifications to add a gradient




Wormhole

!react@programming.dev

founded 11 months ago
MODERATORS