-54

Pretty critical PR for rust-msi is getting held up because the maintainer understands the intent but not why this works (github.com)

submitted 6 months ago* (last edited 6 months ago) by Aatube@kbin.melroy.org to c/rust@programming.dev

18 comments fedilink hide all child comments

Not to throw shade, just wishing that somebody here can understand. Whenever an input is reasonably long, an analyzing function will crash, and this PR aims to fix that with a mechanism that contradicts the maintainer's understanding while a similar C implementation does not need this fix. ~~Clearly, the maintainer has not heard a certain programming mantra...~~

you are viewing a single comment's thread
view the rest of the comments

[-] jwaters42@beehaw.org 47 points 6 months ago

After the xz debacle, I think we should resist the temptation to rush maintainers into accepting code that they don't fully understand.

[+] Aatube@kbin.melroy.org -14 points 6 months ago

Yeah, I'm just asking if anyone actually understands this facet.

[-] towerful@programming.dev 24 points 6 months ago

No you aren't.
The title is demeaning.
"don't want to throw shade" as if we all know what's going on except the people involved in the link.
"Clearly the maintainer hasn't heard of a certain..." Haha, we are in the same group, right? We know what's up, guys... Right? Haha, look at these losers.

Never mind that you are applying a time pressure on open source maintainers to try and merge a change they don't understand. Not very respectful. And quite frankly, in extremely bad taste considering the recently revealed xz social engineering.

Where is the question?
There isn't a single question mark in your post. You frame it as if their problem and they don't understand.
Even here, where you are so close to asking, you make it sound like you are checking that everyone here understands.