105
submitted 9 months ago by RedditEnjoyer@lemmy.world to c/linux@lemmy.ml
you are viewing a single comment's thread
view the rest of the comments
[-] deadbeef79000@lemmy.nz 63 points 9 months ago* (last edited 9 months ago)

rm -rf ${var}/ is a disaster waiting to happen.

Always do rm -rf "${var:?}/" so that the script aborts if the variable is empty. Or better yet rm -rf "./${var:?}/".

Edited to add quotes. Always quote a path: it might have spaces in it, without quotes that will become multiple paths! Which would also have avoided the particular bug in question.

[-] mumblerfish@lemmy.world 18 points 9 months ago

Is there not also a way to disallow empty variables in the script, I think it is set -u? Then you don't have to keep thinking "should I add a :? here because if empty it may lead to disaster" all the time. Might be even safer.

[-] UnityDevice@startrek.website 27 points 9 months ago

set -euo pipefail at the top of every script makes stuff a lot safer. Explanation here.

[-] deadbeef79000@lemmy.nz 8 points 9 months ago

Yep! I always do this too.

TL;DR: e aborts the whole script on a non-zero error. u aborts when using an undefined variable. -o pipefail aborts a piped compound command when one of the piped commands fail.

Any other way lies madness. Or erasing the whole filesystem apparently!

load more comments (1 replies)
load more comments (6 replies)
this post was submitted on 22 Mar 2024
105 points (88.9% liked)

Linux

48654 readers
454 users here now

From Wikipedia, the free encyclopedia

Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991 by Linus Torvalds. Linux is typically packaged in a Linux distribution (or distro for short).

Distributions include the Linux kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word "Linux" in their name, but the Free Software Foundation uses the name GNU/Linux to emphasize the importance of GNU software, causing some controversy.

Rules

Related Communities

Community icon by Alpár-Etele Méder, licensed under CC BY 3.0

founded 5 years ago
MODERATORS