413

submitted 1 year ago by hairinmybellybutt@lemmy.world to c/programmerhumor@lemmy.ml

32 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[-] xmunk@sh.itjust.works 9 points 1 year ago

If you're in a language that supports it, please don't use if (false) use if ($disallowAllUsers = false && $whateverTheRealConditionIs)

[-] PlexSheep@feddit.de 6 points 1 year ago

Never seen this, what language or buildsystem is this?

[-] xmunk@sh.itjust.works 3 points 1 year ago* (last edited 1 year ago)

That specific language is PHP, but the tip is applicable in any language that supports inline assignment.

[-] TheOctonaut@mander.xyz 6 points 1 year ago

if (true === $wantToCauseErrorsForFun) {
    badOldFunction();
}

[-] kogasa@programming.dev 1 points 1 year ago

The assignment syntax is too close to comparison, which is what is more typical in that position. I would recommend

const bool _isFeatureEnabled = false;
if (_isFeatureEnabled &amp;&amp; ...)

if not a proper feature flag (or just remove the code).

[-] SpaceNoodle@lemmy.world -1 points 1 year ago

It seems much worse to use a setter in an if statement.

[-] xmunk@sh.itjust.works 0 points 1 year ago

Think of it as inline attribution/documentation.

this post was submitted on 21 Nov 2023

413 points (96.6% liked)

Programmer Humor

32572 readers

180 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago

MODERATORS