this post was submitted on 16 Nov 2023
10 points (85.7% liked)

Programming

24044 readers
711 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 2 years ago
MODERATORS
snowe@programming.dev
Ategon@programming.dev
MaungaHikoi@lemmy.nz
UlrikHD@programming.dev
10
Why does a control path not execute in this function? (lemm.ee)
submitted 2 years ago by milon@lemm.ee to c/programming@programming.dev
12 comments fedilink hide all child comments
 

In VS I am told this function "does not return a value in all control paths." A bot told me specifically the issue is with this line: else if (letter + key <= 90). It said that if the outcome results in letter + key equally exactly 90 then a value is not returned, but I thought that was covered where '<=' means 'less than or equals.'

char rotate(char letter, int key)
{
    if (isalpha(letter) == true)
    {
        if (letter + key > 90)
        {
            int overage = letter + key - 90;
            letter = 64 + overage;

            while (letter > 90)
            {
                overage = letter - 90;
                letter += overage;
            }

            return letter;
        }

        else if (letter + key &lt;= 90)
        {
            letter += key;
            return letter;
        }
    }

    else if (isalpha(letter) == false)
    {
        return letter;
    }
you are viewing a single comment's thread
view the rest of the comments
[–] ShaunaTheDead@kbin.social 10 points 2 years ago* (last edited 2 years ago)

It's not at all necessary, but I find it makes much easier to read code if you instead only use if statements and just return early when you're in a function. For example, you could check isalpha(letter) == true is true then check letter + key &lt;= 90 do the letter += key; return letter; then since letter + key must be > 90 if it didn't already return a value, then you can do the while statement and return letter without needing an if statement at all. Then the isalpha(letter) == false is also unncessary, just return letter at the end.

Like this:

char rotate(char letter, int key)
{
  if (isalpha(letter)
  {
    if (letter  + key &lt;= 90)
    {
        letter += key;
        return letter;
    }

    do the while loop here
  }

  return letter;
}