24
[Release][v0.1.25] Implementing user requests
(lemmy.world)
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 11 Jul 2023
24 points (87.5% liked)
Summit
708 readers
5 users here now
Community to discuss Summit, a Lemmy reader for Android.
App (Play Store): https://play.google.com/store/apps/details?id=com.idunnololz.summit
APK: https://github.com/idunnololz/summit-for-lemmy/releases
Patreon: https://patreon.com/SummitforLemmy
Ko-Fi: https://ko-fi.com/summitforlemmy
Website: https://summit.idunnololz.com/
founded 1 year ago
MODERATORS
I see. I'm guessing on Reddit, there was no server setting to hide read posts whereas on lemmy there is. This kind of complicates things as there are two ways to implement this feature. One that is 100% client side and the other that is server side.
Well, I actually think it is kinda implemented on Reddit, but not as it is with Lemmy web (I don't recall this feature being persistent across different apps... anyway I'm used for this to being client side only, if using the Lemmy implementation helps for the clients here then I guess is fine???
IDK man 😅
Anyway your current implementation is a step up ahead because no other app has it working in conjunction yet.
May I ask why do we need to uncheck that setting in the the lemmy web to begin with?
My implementation uses Lemmy's server side logic to hide read posts. Therefore, if "Show read posts" was enabled, the "Hide read" button would do nothing. To avoid user confusion, the "Hide read" button is only shown when "Show read posts" is disabled. After thinking about this a bit more, I think I'm coming to the conclusion that this group of features should all be client sided. This is going to take some time to implement. I'll work on it tomorrow. I'm also in the middle of implementing gesture actions so this will have to wait until I am done with that.
@Alpagu@lemmy.world ^^
Thank you 👏
Yeah, I think it is better to keep this client side let better show read posts option keep working globally and have the client to hide read posts with the FAB button.
I think Connect for Lemmy does something like this (no switch though) without messing with Lemmy's settings.
It has two options, one for mark as read while scroll and the other to hide the read posts but hidden posts does not interfiere with other apps.
Anyway I think it is a big progress to have a button on a FAB already, keep on the good job man!
I think there is an error in the implementation point. I used sycn for lemmy for a long time. This is something I'm used to. Server setting should be applied to the fab button. The hide read and show read feature in the server setting should be applied to the fab button. There should not be two different systems.