I use iD editor almost every time. It's simple to use and I can use it on nearly any computer I have access to. usually put on a podcast for 30min-1h and map while I listen.

On my phone I have Vespucci installed. It's a lot slower going compared to PC but it can scratch the itch when I'm bored out and about. I use OSMand for actually using the map data.

Street Complete is slick and makes it easy to add a ton of stuff but that is geared towards polishing up the unknown details of stuff that is already mapped. I'd rather finish adding unmapped roads and sidewalks than telling OSM what materials they're made of.

I like to map land use. I spent some time on a volunteer fire department and working with their K9 Search and Rescue team on real calls and training. Land nav and good mapping is super important to them so I put some extra effort to make it as useful as possible.

It mildly annoys me when mappers add big sections of natual wood but completely ignore the big swampy wetland or other obvious things within that area like ponds. I think some people map it just so it looks nice but a little detail matters when you're there in person and have to get around.