846
The eye-opener commit
(discuss.tchncs.de)
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 23 Nov 2023
846 points (97.9% liked)
Programmer Humor
32483 readers
166 users here now
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
founded 5 years ago
MODERATORS
I mean, that 'could' be a straight up wrong thing to do if some of the calls were expecting errors to be able to escape. Yea, it'd be super weird and I don't know if .NET would marshall them anywhere, but in some systems, that sort of, "obvious" fix could break shit. Sure, it'd be something doing something weird and kinda' dumb, but ... don't we see "weird and dumb" all the time??
oh yeah I just logged and rethrew, so it shouldn't have had any behavior change, but I could have broken something I make mistakes all the time.
The errors we were seeing in logs were like logic or application errors that we just didn't see before. My changes really shouldn't have caused.
I think that was the right approach, then again didn't you have through a pull request or at least a code review? Knowing that would give raise to so many "errors" you should have had some sort of communication beforehand.
I don't blame you, more the workflow and ironically the manager
Oh that was like years ago! Probably SVN, we on-boarded Git a little while after.
No pull requests, you just manually merged back then. It's definitely a workflow improvement we adopted later and we as a company and as an industry have gotten better.
lol, the thing was just that my manager asked me what I did and I told him. Him getting another dev to "fact-check" me after is what bothered me a bit. I am usually the type of look into issues rather than brush them off and I am the first to confess to a screw up. Which is why I was irked.