This is a most excellent place for technology news and articles.
My guess would be they didn't like how verbose it was to supress the warning for all the compilers they use, or maybe they have a coding standard not to suppress warnings, and this was a workaround for that ๐
actually not sure, as they do use #pragma GCC diagnostic ignored in a couple of places :
#pragma GCC diagnostic ignored
https://github.com/git/git/blob/8d96f09e9245ddf80c1981476fcbac8c4bb4125f/compat/win32/headless.c#L14
https://github.com/git/git/blob/8d96f09e9245ddf80c1981476fcbac8c4bb4125f/compat/regex/regex.c#L20
but apparently that disables it for everything after that line in the file though:
https://stackoverflow.com/questions/48426484/concise-way-to-disable-specific-warning-instances-in-clang#comment83878587_48426846
I think the second answer on that stackoverflow post might be better than false_but_the_compiler_does_not_know_it_ though...
false_but_the_compiler_does_not_know_it_
My guess would be they didn't like how verbose it was to supress the warning for all the compilers they use, or maybe they have a coding standard not to suppress warnings, and this was a workaround for that ๐
actually not sure, as they do use
#pragma GCC diagnostic ignoredin a couple of places :https://github.com/git/git/blob/8d96f09e9245ddf80c1981476fcbac8c4bb4125f/compat/win32/headless.c#L14
https://github.com/git/git/blob/8d96f09e9245ddf80c1981476fcbac8c4bb4125f/compat/regex/regex.c#L20
but apparently that disables it for everything after that line in the file though:
https://stackoverflow.com/questions/48426484/concise-way-to-disable-specific-warning-instances-in-clang#comment83878587_48426846
I think the second answer on that stackoverflow post might be better than
false_but_the_compiler_does_not_know_it_though...