For a lot of us, atproto projects are some of the biggest (most users, most publicized, most code written, etc.) projects we’ve ever done. For me, it’s also my first time working in open source (ironically, someone asked me to be more open about that)

If you can help, pls check out open issues.

I know not everyone thinks highly of atproto around these parts, but please don’t let that get in the way of welcoming a fellow rustacean into the open source world 🦀

you are viewing a single comment's thread
view the rest of the comments

[–] BB_C@programming.dev 8 points 1 year ago (1 children)

Some shallow observations without really getting into the code:

misc

Was hosting labeler/ResNet50_nsfw_model.pth in the repository really necessary?
(I like my --filter=tree:0 clones to be maximally fast and small.)
Why not declare all dependencies in the workspace?
How old is the code (for real)?

`rsky-crypto`

anyhow in library code.
Not liking that multibase dependency much either. I know that base64 at least got re-written since that crate's last update (Nov 6, 2020).

`rsky-feedgen`

serde_cbor is long dead (I was a user myself).
I'm not even sure why serde_cbor and serde_ipld_dagcbor are dependencies anyway.
We moved from lazy_static to once_cell a long time ago. And your use is available in std on stable Rust today.

`rsky-firehose`

Here, all three CBOR dependencies are actually used.
CBOR (the format) used in $CURRENT_YEAR is meh anyway. But I guess that comes from IPLD.

`rsky-identity`

anyhow in library code.

`rsky-pds`

That's quite the dependency list! Too long for me to take a closer look.
How many *base* dependencies does one need? All of them of course!

`rsky-syntax`

lazy_static and anyhow again.

That's all from a code organization and ecosystem PoV. Otherwise, things look normal and not fancy (which is good).

Unfortunately, I don't have the time to look beyond that at this moment.

[–] erlend_sh@lemmy.world 2 points 1 year ago

Appreciate the review! I’ve forwarded it to the dev :)